Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] handle multilines with cmd #2002

Merged
merged 3 commits into from
Jan 2, 2025
Merged

[backend] handle multilines with cmd #2002

merged 3 commits into from
Jan 2, 2025

Conversation

MarineLeM
Copy link
Contributor

Close: #2000

@MarineLeM MarineLeM self-assigned this Dec 5, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 35.32%. Comparing base (8713087) to head (b80c903).
Report is 3 commits behind head on release/1.11.0.

Files with missing lines Patch % Lines
...s/rest/inject/service/ExecutableInjectService.java 0.00% 16 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                  @@
##             release/1.11.0    #2002      +/-   ##
====================================================
- Coverage             35.36%   35.32%   -0.04%     
  Complexity             1424     1424              
====================================================
  Files                   537      537              
  Lines                 16283    16298      +15     
  Branches               1043     1048       +5     
====================================================
  Hits                   5758     5758              
- Misses                10229    10244      +15     
  Partials                296      296

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarineLeM MarineLeM marked this pull request as ready for review December 5, 2024 11:19
@MarineLeM MarineLeM linked an issue Dec 5, 2024 that may be closed by this pull request
Technical payload with cmd and if statement does not work #2000
Closed
@damgouj damgouj self-requested a review December 5, 2024 13:07
damgouj
damgouj requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@damgouj damgouj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with complicated loops and not working, maybe we could try to find a generic way to do like powershell (if it exists for cmd !) ? Thanks !
Capture d’écran 2024-12-06 085942
Capture d’écran 2024-12-06 085649

@MarineLeM MarineLeM changed the base branch from release/1.10.0 to master January 2, 2025 10:13
@MarineLeM MarineLeM changed the base branch from master to release/1.11.0 January 2, 2025 10:18
@MarineLeM
Copy link
Contributor Author

@damgouj ready for a second round, it should now handle complicated loops

@MarineLeM MarineLeM merged commit 100a439 into release/1.11.0 Jan 2, 2025
6 checks passed
@MarineLeM MarineLeM deleted the issue/2000 branch January 2, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damgouj damgouj damgouj approved these changes

Assignees

@MarineLeM MarineLeM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Technical payload with cmd and if statement does not work
2 participants
@MarineLeM @damgouj